test: use more informative errors in test-runner-cli
#55321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Oct 8, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55321 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.01%
==========================================
Files 652 652
Lines 186762 186762
Branches 36099 36107 +8
==========================================
- Hits 165123 165116 -7
- Misses 14902 14905 +3
- Partials 6737 6741 +4 |
atlowChemi
approved these changes
Oct 8, 2024
aduh95
added
the
commit-queue
lpinca
approved these changes
Oct 9, 2024
JakobJingleheimer
approved these changes
Oct 10, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in fdc23b2 |
aduh95
added a commit
that referenced
this pull request
Oct 11, 2024
PR-URL: #55321 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55321 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
marco-ippolito
added
the
dont-land-on-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55321 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
1 is not equal to 0errors give very little info on what's actually going wrong when the test fails. Checking stdout and stderr first almost always gives more informative errors.